On 4/18/24 5:11 AM, Boris Fiuczynski wrote:
On 4/17/24 15:58, Cole Robinson wrote:
Simplest solution is to fill in `active_config` at XML define time as well. The real node_device driver already takes care to free any `active_config` when it live updates this info, so we are safe there. I do not think that it is a good idea to hack the general code which creates in the real environments fake data.
I can't tell how this affects real environments. Is there a place in the udev driver where XML is parsed, and then active_config isn't explicitly updated?
If not, do you object to me pushing this with Michal's ACK? This is causing some pain with virt-manager dev workflow
virNodeDevCapMdevParseXML is used when defining a new mdev and starting a transient mdev but of course not in the udev driver. There updates start mdevctl and parse the returned json to populate the data into the mdev.
I see, but I still don't see how this change causes problems with real environments (the udev driver) - Cole