Re: [libvirt] [PATCH 2/3] Temporarily disable admin API
On Fri, Jun 26, 2015 at 12:45:37PM +0100, Daniel P. Berrange wrote:
On Fri, Jun 26, 2015 at 01:42:01PM +0200, Martin Kletzander wrote:
> Don't listen on the admin socket in the daemon and comment out the
> admin devel files out of specfile.
>
> Library is still being compiled and installed in order to link easily
> without any disturbing modifications to the daemon code.
That will cause RPM to complain about installed but unpackaged
files still.
Oh yes, I'll fix that.
If you don't want to disturb linking / daemon code, you could mark
it
as a noinst_LTLIBRARIES which I think should cause libtool to then
statically link it into libvirtd. So you'll still avoid disturbing
code but also avoid installation. Likewise skip header file install
and .pc file.
I have to keep the libvirt-admin.la as lib_LTLIBRARIES and not
noinst_LTLIBRARIES because we still need the libvirt-admin.so.1.2.17
to be installed so rpm can pick up so libvirtd can be dynamically
linked with that. We just need to remove the libvirt-admin.so
(unversioned, would be used for -devel package) in the %install phase
for now as we do with all the .la, .a and other files so rpm doesn't
complain.
v2 coming up.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)