On Wed, 2016-11-23 at 14:00 +0000, Daniel P. Berrange wrote:
On Wed, Nov 23, 2016 at 08:55:03AM -0500, John Ferlan wrote:
Beyond that - both patches seem fine.... Given recent discussion about removing an older Xen driver from libvirt:
http://www.redhat.com/archives/libvir-list/2016-November/msg00911.h tml
causes me to wonder is there "some version" in history that perhaps can be removed from/for vbox support? Perhaps cutting down on the number of various variant compilation options based on some VBOX_API_VERSION?
VirtualBox 4.0 was relesaed in December 2010. So IMHO we could quite reasonably kill all versions < 4
Regards, Daniel
I definitely am in favor of killing support for < 4 as even v4 is no longer officially supported by upstream and does not even install on more modern distros, e.g Fedora 25. I also have other patches to this driver pending submission where I had to write code to handle <v3 versions specifically so removal of those versions would make maintenance much easier. I can submit relevant patches to remove to remove support for those old versions once this series gets pushed. Regards, Dawid