Re: [libvirt] [PATCH 5/9] Implement controller hotplugging

This enables to hot-add disk controllers without attached disks into the system. Previously, it was only possible to (implicitly) add disk controllers in the static machine configuration. Notice that the actual functionality is only available for qemu at present, but other emulators can be extended likewise.

Signed-off-by: Wolfgang Mauerer <wolfgang.mauerer(a)siemens.com&gt; Signed-off-by: Jan Kiszka <jan.kiszka(a)siemens.com&gt; --- src/domain_conf.c | 26 +++++++++++++++++++++++--- src/domain_conf.h | 2 ++ src/libvirt_private.syms | 1 + src/qemu_driver.c | 21 +++++++++++++++++---- 4 files changed, 43 insertions(+), 7 deletions(-) diff --git a/src/domain_conf.c b/src/domain_conf.c index d0fda64..ea51fda 100644 --- a/src/domain_conf.c +++ b/src/domain_conf.c @@ -647,7 +647,6 @@ void virDomainRemoveInactive(virDomainObjListPtr doms, } - /* Parse the XML definition for a disk * @param node XML nodeset to parse for disk definition */ @@ -2554,6 +2553,27 @@ virDomainDeviceDefPtr virDomainDeviceDefParse(virConnectPtr conn, #endif +static int virDomainControllerCompare(virDomainControllerDefPtr a, + virDomainControllerDefPtr b) { + if (a->pci_addr.bus == b->pci_addr.bus) { + if (a->pci_addr.domain == b->pci_addr.domain) + return a->pci_addr.slot - b->pci_addr.slot; + + return a->pci_addr.domain - b->pci_addr.domain; + } + + return a->pci_addr.bus - b->pci_addr.bus; +} + + +int virDomainControllerQSort(const void *a, const void *b) +{ + const virDomainControllerDefPtr *da = a; + const virDomainControllerDefPtr *db = b; + + return virDomainControllerCompare(*da, *db); +} +