Re: [libvirt] [PATCH v2 1/4] domain_conf: always set primary video device as primary

We always place primary video device at first place, to make it easier to create a qemu command or format an xml, but we should also set the primary boolean for primary video device to 'true'. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com&gt; --- diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 3b15cb4..5e9c096 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11918,7 +11918,7 @@ virDomainVideoDefParseXML(xmlNodePtr node, if ((primary = virXMLPropString(cur, "primary")) != NULL) { if (STREQ(primary, "yes")) - def->primary = 1; + def->primary = true; VIR_FREE(primary); }

@@ -16060,6 +16060,10 @@ virDomainDefParseXML(xmlDocPtr xml, goto error; } } + /* if not specified by user mark the first video as primary */ + if (n && !primaryVideo) + def->videos[0]->primary = true; +