On Mon, Jan 25, 2010 at 02:29:35PM +0100, Daniel Veillard wrote:
On Mon, Jan 25, 2010 at 05:30:23AM -0700, Eric Blake wrote:
According to Daniel P. Berrange on 1/25/2010 4:15 AM:
So, what is the oldest version of autoconf and automake that libvirt will insist on supporting?
RHEL5 is the minimum required platform, including full bootstrap from GIT source. This implies automake-1.9.6-2.1 and autoconf-2.59-12
Fair enough. That said, my patch to rename to configure.ac and use the more modern AC_CONFIG_HEADERS is still relevant, as both of those were supported in autoconf 2.59. I noticed the patch got attached with binary mime type last time; (I'm still fighting with email configuration of the machine where I first built the patch), so here it is again in plain text. [..] diff --git a/configure.in b/configure.ac
Sorry for being ignorant but what's the interest of renaming ? what does that change in practice ?
IIUC, it is simply that "configure.ac" is the recommended naming convention from autoconf developers. Functionally I don't believe there's any difference.
similarity index 99% rename from configure.in rename to configure.ac
index 8cbbfe5..32f376e 100644 --- a/configure.in +++ b/configure.ac @@ -3,7 +3,7 @@ dnl Process this file with autoconf to produce a configure script. AC_INIT([libvirt], [0.7.5]) AC_CONFIG_SRCDIR([src/libvirt.c]) AC_CONFIG_AUX_DIR([build-aux]) -AM_CONFIG_HEADER([config.h]) +AC_CONFIG_HEADERS([config.h]) dnl Make automake keep quiet about wildcards & other GNUmake-isms AM_INIT_AUTOMAKE([-Wno-portability])
Independantly of renaming, that looks fine to me,
ACK to the whole patch from me, including the rename - we might as well follow the best practice here. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|