Re: [libvirt PATCH 23/23] build: add syntax-check rules for undesirable terms
On a Friday in 2020, Peter Krempa wrote:
On Fri, Jun 19, 2020 at 10:33:00 +0100, Daniel Berrange wrote:
> We don't check for "master", because there are too many
> cases that we're not trying to eliminate at this time.
>
Even if you consider the terms undesirable, consider using them in the
commit summary instead of mentioning what you're not trying to do.
> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
> ---
> build-aux/syntax-check.mk | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
I don't think there's a technical reason forbiding these and it's almost
borderline censorship. I refuse to put my R-b on this one.
Given how many files are excepted, I think it's a waste of electricty to
even check for these.
Jano
Attachments:
- signature.asc (application/pgp-signature — 488 bytes)