Re: [libvirt] [PATCH 3/6] Format NULL bitmap as an empty string

On 06/05/14 13:25, Ján Tomko wrote:

This simplifies the usage in {libxl,qemu}DomainGetNumaParameters and it's needed for consistent error reporting in virBitmapFormat.

Also remove the forgotten ATTRIBUTE_NONNULL marker. --- src/libxl/libxl_driver.c | 3 +-- src/qemu/qemu_driver.c | 2 +- src/util/virbitmap.c | 6 +----- src/util/virbitmap.h | 3 +-- 4 files changed, 4 insertions(+), 10 deletions(-)

You should mention the new semantics when NULL is passed in the function comment. ACK with that added. Peter