Re: [Libvir] PATCH: Support NIC model selection for QEMU/KVM

Daniel P. Berrange wrote: > On Mon, Oct 22, 2007 at 04:33:40PM -0400, Daniel Veillard wrote: > > On Mon, Oct 22, 2007 at 03:44:38PM -0400, Jim Paris wrote: > > > Hi, > > > > > > Sometime between kvm-36 and kvm-46 I ran into problems with the > > > default QEMU network card (ne2k-pci). Switching it fixed the > > > problems, but libvirt doesn't support changing the NIC model. > > > These patches add support for: > > > > > > <interface> > > > <nic model="rtl8139"/> > > > </interface> > > > > > > which becomes > > > > > > qemu -net nic,model=rtl8139,mac=... > > > > > > By default, no model is appended to the qemu command line, as before. > > > Documentation update & some fixes are included too. > > > > Hum, > > > > I would really prefer if we were able to identify the issue and > > fix it transparently for the user (for example by detecting the > > kvm version if possible) rather than add an option in the permanent > > data file just to make stuff work. I hope this is possible, but > > can't really tell. > > In Fedora/RHEL we simply switched Xen, QEMU and KVM to all use rtl8139 by > defualt since ne2k is crap. Getting it fixed upstream might be best. We could also just have libvirt always append "model=rtl8139", but I'd be concerned that we could break existing VMs for some users if we swap out the network card unexpectedly. An upstream change would have the same problem. Regardless of what the defaults are, I don't think exposing a knob that lets you control what NIC the guest sees is that much of a hack; describing the guest hardware is what the config xml is mostly for.