Re: [libvirt] [libvirt-python][PATCH] maint: Require libvirt-3.4.0 at least
On Thu, Sep 14, 2017 at 01:41:08PM +0200, Michal Privoznik wrote:
Currently, we require 0.9.11. However, some APIs are missing
there and thus sanity check fails:
DEBUG: /usr/bin/python sanitytest.py build/lib.linux-s390x-2.7
/usr/share/libvirt/api/libvirt-api.xml
DEBUG: FAIL virStream.sparseRecvAll (Python API not mapped to C)
DEBUG: FAIL virStream.sparseSendAll (Python API not mapped to C)
DEBUG: error: command '/usr/bin/python' failed with exit status 1
I'm not sure how to fix that so raising minimal required libvirt
version is the solution.
I think the whole point is to be able to compile with any older (sane)
version of libvirt, so you should *not* do this. We already have a
mechanism for this, it's just that the naming of these functions doesn't
fit it and it needs to be adjusted IIRC. See function shouldSkip() in
generator.py.
From me this is NACK until convinced otherwise.
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)