Re: [libvirt] [PATCH 19/16] save: add virsh commands for manipulating save files
On 07/21/2011 05:50 AM, Daniel P. Berrange wrote:
On Wed, Jul 20, 2011 at 02:54:25PM -0600, Eric Blake wrote:
> Now you can edit a saved state file even if you forgot to grab
> a dumpxml file prior to saving a domain. Plus, in-place editing
> feels so much nicer.
>
> * tools/virsh.c (cmdSaveImageDumpxml, cmdSaveImageDefine)
> (cmdSaveImageEdit): New commands.
> * tools/virsh.pod (save-image-dumpxml, save-image-define)
> (save-image-edit): Document them.
> ---
>
> Needs the next patch to be testable. 'save-image-edit' feels a bit
> long, but I couldn't think of something shorter. Should I keep the
> new save-image-* commands in the main domain group, or should I create
> a new save-image group, in case we add more later?
I think the main group is fine - we alreaddy have plenty of other
save related commands there.
We can always regroup later, so for now I left it in the domain group.
ACK
Thanks; I've now pushed 17-19. That leaves 16 and 20 needing a v3
posting (coming up shortly). That is, the new APIs are now committed,
and virsh knows how to use them, but without 16 and 20, no domain
actually implements the new dxml modifications of save state image yet.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org