On 6/20/19 8:51 AM, Peter Krempa wrote:
Change the example and add a recommendation to use disk target rather than path.
Signed-off-by: Peter Krempa <pkrempa@redhat.com> --- docs/formatsnapshot.html.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/formatsnapshot.html.in b/docs/formatsnapshot.html.in index 1bbbf06205..a19e91b4d5 100644 --- a/docs/formatsnapshot.html.in +++ b/docs/formatsnapshot.html.in @@ -140,8 +140,8 @@ <dd>This sub-element describes the snapshot properties of a specific disk. The attribute <code>name</code> is mandatory, and must match either the <code><target - dev='name'/></code> or an unambiguous <code><source - file='name'/></code> of one of + dev='name'/></code> (recommended) or an unambiguous + <code><source file='name'/></code> of one of
I like it. I also know that for checkpoints, you wanted me to ONLY accept the disk target name rather than copying the snapshot practice of also supporting a file name. This gives me a stronger reason to follow up with that request. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org