Re: [libvirt] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

On 2/13/16 23:41, Peter Xu wrote: > Please help review whether the interface suits our need, also please > point out any error I have made. I tested QEMU with these patches and they were able to work on a native ARM64 machine.

> > One question: how should I make this command "ARM only"? I see that > in qmp-commands.hx, I can use something like "#if defined > TARGET_ARM" to block out ARM specified commands, however how should > I do the similiar thing in qapi-schema.json? This situation is similar to "rtc-reset-reinjection", right? I think You can disable this feature on other arch's by setting QERR_FEATURE_DISABLED in file like monitor.c.