Re: [libvirt] [PATCH] storage: Sanitize pool target paths
On 05/20/2010 12:19 PM, Daniel P. Berrange wrote:
On Thu, May 20, 2010 at 12:04:05PM -0400, Cole Robinson wrote:
> Spurious / in a pool target path makes life difficult for apps using the
> GetVolByPath, and doing other path based comparisons with pools. This
> has caused a few issues for virt-manager users:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=494005
> https://bugzilla.redhat.com/show_bug.cgi?id=593565
>
> Add a new util API which removes spurious /, virFileSanitizePath. Sanitize
> target paths when parsing pool XML, and for paths passed to GetVolByPath.
If we're going todo this shouldn't we resolve symlinks, and
canonicalize any '..' or '.' components in the path. IIRC
gnulib had something for this ?
Daniel
Certainly '..' and '.', but maybe only resolve symlinks on path lookup?
I don't think users would want their symlinks resolved away in the pool
XML, they could use a symlink named /media to point to a horribly long
complicated /mnt path.
- Cole