On Thu, Aug 28, 2025 at 14:54:40 +0200, Stefan Kober wrote:
This patchset adds the necessary functionality to support disk hotplugging in the CH driver.
Some alias handling that can be extended to other device types is added, in order to allow detaching the devices via the Cloud Hypervisor API.
Stefan Kober (13): ch: add DomainAttachDevice skeletons ch: add DomainDetachDevice skeletons ch: add ch_hotplug.{h,c} files to CH build ch: call into ch_hotplug implementation ch: pass disk alias to CHV ch: add ch_alias.{c,h} for device alias handling ch: add virCHMonitorPut function ch: use MonitorPut in MonitorPutNoContent ch: add disk attach functionality ch: assign aliases in ProcessPrepareDomain ch: Add virCHMonitorRemoveDevice function ch: implement disk device hot removal NEWS: announce disk hotplug support for ch
I didn't have time (or expertise on the cloud hypervisor specifics) to do proper review but I've noticed that the patches introduce temporary problems (e.g. failed build) in between the patches. Our guidelines state that both the build and tests must pass after each commit (to e.g. allow good bisectability): https://libvirt.org/hacking.html#preparing-patches Make sure that you run a build and test after each commit. No need to send another series yet, but be prepared to fix those problems. Some things my testing showed: ../../../libvirt/src/ch/ch_driver.c:2349:46: error: omitting the parameter name in a function definition is a C23 extension [-Werror,-Wc23-extensions] 2349 | const char */*xml*/, | ^ 1 error generated. - addition to po/POTFILES being misplaced - misplaced function declarations in header files (broken build where function is not declared yet)