On Fri, Mar 22, 2013 at 11:22:20AM +0100, Michal Privoznik wrote:
On 22.03.2013 11:11, Christophe Fergeau wrote:
virtxml was doing its own loading of the libosinfo database, and gvir_designer_init() was loading it a second time. By adding a GVirDesignerDomain::osinfo_db property, applications can share the same OsinfoDb as libvirt-designer. The association is made per libvirt-designer domain for more flexibility. --- examples/virtxml.c | 2 +- libvirt-designer/libvirt-designer-domain.c | 34 ++++++++++++++++++++++++++-- libvirt-designer/libvirt-designer-domain.h | 3 ++- libvirt-designer/libvirt-designer-internal.h | 3 --- libvirt-designer/libvirt-designer-main.c | 12 ---------- libvirt-designer/libvirt-designer-main.h | 2 ++ 6 files changed, 37 insertions(+), 19 deletions(-)
ACK, the global variables look really ugly.
Fwiw, I forgot to tag this as PATCHv3, this is the 3rd iteration of this patch. Christophe