On 11/7/24 17:19, Peter Krempa wrote:
On Wed, Nov 06, 2024 at 15:31:56 +0100, Boris Fiuczynski wrote:
Let us introduce the xml and reply files for QEMU 9.2.0 on s390x.
qemu-9.2 is not yet out ...
Signed-off-by: Shalini Chellathurai Saroja <shalini@linux.ibm.com> Signed-off-by: Boris Fiuczynski <fiuczy@linux.ibm.com> --- tests/domaincapsdata/qemu_9.2.0.s390x.xml | 311 + .../caps_9.2.0_s390x.replies | 36741 ++++++++++++++++ .../qemucapabilitiesdata/caps_9.2.0_s390x.xml | 3752 ++ 3 files changed, 40804 insertions(+) create mode 100644 tests/domaincapsdata/qemu_9.2.0.s390x.xml create mode 100644 tests/qemucapabilitiesdata/caps_9.2.0_s390x.replies create mode 100644 tests/qemucapabilitiesdata/caps_9.2.0_s390x.xml
...
but your .replies file claims:
+ "return": { + "qemu": { + "micro": 0, + "minor": 2, + "major": 9 + }, + "package": "v9.2.0" + }, + "id": "libvirt-2" +} +
So that seems doctored. We're okay with in development versions but they must be captured from a real qemu build without any shenanigans.
Also don't forget to mention in the commit message which exact commit this was based on.
Additionally if you want to commit an in-development version you also need to volunteer to update this once the real qemu-9.2 is released.
I will look up the QEMU commit id we used to generate the replies file and add it to the package returned as well as mention it in the commit message. We plan to update these files with the future GA qemu-9.2. -- Mit freundlichen Grüßen/Kind regards Boris Fiuczynski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Wolfgang Wendt Geschäftsführung: David Faller Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294