On Fri, Jul 28, 2017 at 12:38:59PM -0400, John Ferlan wrote:
Rather than overload virObjectUnlock as commit id '77f4593b' has done, create a separate virObjectRWUnlock API that will force the consumers to make the proper decision regarding unlocking the RWLock's. This restores the virObjectUnlock code to using the virObjectGetLockableObj as well.
Signed-off-by: John Ferlan <jferlan@redhat.com> --- src/conf/virdomainobjlist.c | 36 ++++++++++++++++++------------------ src/libvirt_private.syms | 1 + src/util/virobject.c | 41 +++++++++++++++++++++++++++-------------- src/util/virobject.h | 4 ++++ 4 files changed, 50 insertions(+), 32 deletions(-)
The virObjectLockRead and virObjectLockWrite should be probably renamed to virObjectRWLockRead and virObjectRWLockWrite for consistency with the virObjectRWUnlock. Reviewed-by: Pavel Hrdina <phrdina@redhat.com>