Re: [libvirt] [PATCH 2/5] interface: fix netcf based backend naming

Tuesday, 9 October 2012


On 10/06/2012 01:20 PM, Doug Goldstein wrote:
...
 All other backends for virInterface or other HVs implementations of
 virInterface list their own names for the name instead of the generic
 'Interface' value. This does the same for the netcf based backend.
 ---
  src/interface/interface_backend_netcf.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-) 
ACK.  However, before pushing, I squashed in one more fix (based on what
I saw you do in 3/5):

@@ -806,6 +806,10 @@ static virInterfaceDriver interfaceDriver = {
 };

 int interfaceRegister(void) {
-    virRegisterInterfaceDriver(&interfaceDriver);
+    if (virRegisterInterfaceDriver(&interfaceDriver) < 0) {
+        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
+                       _("failed to register netcf interface driver"));
+        return -1;
+    }
     return 0;
 }

-- 
Eric Blake   eblake(a)redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


    