Re: [libvirt] [PATCH v2] qemu: Move last error save/restore to qemuBuildNetCommandLine

On 03/15/2016 07:36 AM, John Ferlan wrote: > Commit 'ef2ab8fd' moved just the virDomainConfNWFilterTeardown and left > the logic to save/restore the current error essentially doing nothing > in the error path for qemuBuildCommandLine. So move it to where it > was meant to be. > > Although the original code would reset the filter on command creation > errors after building the network command portion and commit 'ef2ab8fd' > altered that logic, the teardown is called during qemuProcessStop from > virDomainConfVMNWFilterTeardown and that code has the save/restore > last error logic, so just allow that code to handle the teardown rather > than running it twice. The qemuProcessStop would be called in the failure > path of qemuBuildCommandLine. > > Signed-off-by: John Ferlan <jferlan(a)redhat.com&gt; > --- > v1: > http://www.redhat.com/archives/libvir-list/2016-March/msg00566.html > > Changes - just move the save/restore error logic from mainline to the > BuildNetCommandLine function where it's used. > > src/qemu/qemu_command.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >