Re: [libvirt] [PATCH] tests: skip virfirewalltest on non-Linux systems

On 05/02/2014 11:37 AM, Daniel P. Berrange wrote: > On Thu, May 01, 2014 at 10:51:02PM +0400, Roman Bogorodskiy wrote: >> Currently firewalling is supported on Linux only, so skip the >> virfirewalltest on other platforms. >> --- >> tests/virfirewalltest.c | 58 +++++++++++++++++++++++++++++-------------------- >> 1 file changed, 35 insertions(+), 23 deletions(-) > > This code is actually intended to be portable across all platforms. > > What actual problem are you seeing. > virFirewallValidateBackend checks for the presence of iptables and ebtables. This also breaks starting networks without ebtables installed, even if mac_filter is turned off. Would it be OK to remove this check and only fail when the commands are actually executed?