On Thu, Jun 03, 2010 at 07:58:43AM -0600, Eric Blake wrote:
On 06/03/2010 04:08 AM, Daniel P. Berrange wrote:
On Wed, Jun 02, 2010 at 03:53:12PM -0600, Eric Blake wrote:
On Fedora 13 with sufficient mingw32-* packages installed, running ./autobuild.sh failed to cross-compile to mingw because mingw32-pthreads installed a broken <pthread.h>. With that issue fixed, the build still failed due to use of O_SYNC.
Indeed you shouldn't install mingw32-pthreads - it horribly pollutes the global namespace & libvirt doesn't want it - we use Win32 native threads
That would be nice, if yum didn't also insist upon removing everything else mingw related:
Removing: mingw32-pthreads noarch 2.8.0-10.fc13 @fedora 936 k Removing for dependencies: mingw32-gcc x86_64 4.4.2-2.fc13 @fedora 3.1 M mingw32-gcc-c++ x86_64 4.4.2-2.fc13 @fedora 24 M mingw32-gettext noarch 0.17-12.fc12 @fedora 20 M mingw32-glib2 noarch 2.23.4-1.fc13 @fedora 7.6 M mingw32-glibmm24 noarch 2.23.2-1.fc13 @fedora 6.4 M mingw32-gnutls noarch 2.6.4-3.fc13 @fedora 2.4 M mingw32-libsigc++20 noarch 2.2.4.2-1.fc12 @fedora 1.7 M mingw32-libxml++ noarch 2.26.0-3.fc12 @fedora 1.2 M
What's weird is that I don't recall having mingw32-pthreads installed on a 32-bit fedora 13; it must be something about the 64-bit x86_64 packages that is mistakenly sucking in this less-than-stellar package.
Hmm, that sounds like a packaging bug to me - pthreads certainly used to be optional :-(
So, is the libvirt patch worth installing, while we wait for the eventual fix of dependencies to not force mingw32-pthreads on 64-bit users?
How about changing configure.ac so that it defaults to looking for win32 threads on Win32, rather than trying pthreads Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|