Re: [libvirt] [PATCH] libxl: Implement basic video device selection

> + b_info->video_memkb = def->videos[0]->vram ? > + def->videos[0]->vram : > + LIBXL_MEMKB_DEFAULT; > While testing this, I noticed that libvirt will set vram to 9216 if not specified. E.g.

With type='vga', libxl will then fail to start the domain libxl: error: libxl_create.c:253:libxl__domain_build_info_setdefault: videoram must be at least 16 MB for STDVGA on QEMU_XEN This could be handled in libxlDomainDeviceDefPostParse(), where we can check for sane vram values for the various VIR_DOMAIN_VIDEO_TYPE_*, or set sane defaults if vram is not specified.