On Mon, Aug 26, 2019 at 04:06:47PM +0200, Ján Tomko wrote:
On Fri, Aug 23, 2019 at 04:11:42PM +0100, Daniel P. Berrangé wrote:
When using systemd socket activation the --listen arg has no effect. This is confusing to users upgrading from previous versions of libvirt as their config is silently ignored. Turn use of --listen into a fatal error when sockets are passed from systemd.
This helps the admin discover the change in behaviour and thus decide whether to stick with socket activation or revert to previous behaviour.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- src/remote/libvirtd.pod | 33 ++++++++++++++++++++++++++++++++- src/remote/remote_daemon.c | 7 +++++++ 2 files changed, 39 insertions(+), 1 deletion(-)
+#ifdef WITH_IP + if (act && ipsock) { + VIR_ERROR(_("--listen parameter not permitted with systemd activation sockets"));
Would it be possible to somehow fit in a reference to the man page?
Sure VIR_ERROR(_("--listen parameter not permitted with systemd activation " "sockets, please see 'man libvirtd' for further guidance."));
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Jano
Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|