Re: [libvirt PATCH 04/28] util: rename iptables helpers that will become the frontend for ip&nftables
On 5/3/23 11:54 AM, Daniel P. Berrangé wrote:
On Sun, Apr 30, 2023 at 11:19:19PM -0400, Laine Stump wrote:
> These toplevel functions have no iptables-specific code, except that
> they each call a lower-level internal function that *is* iptables
> specific. As a preparation to supporting use of either iptables or
> nftables, rename these functions from iptablesXXX to virNetfilterXXX.
Anyone have any thoughts on virNetfilterXXX vs virNetFilterXXX ?
I would probably have gone for the latter, but its pretty minor
so not too fussed about it.
Either way is okay with me. "netfilter" is a single word that is usually
lower case, which is why I made it "virNetfilter" (first letter of a
word in the middle of the identifier has to be capitalized to follow
"camelCase"). But of course if you're thinking of it as the generic term
"net filter" rather than the specific "netfilter", then
"virNetFilter"
is better.