Re: [libvirt] [PATCH v2 3/4] caps: introduce new qemu capability for vgamem_mb device property

14 Nov 2014


      On 11/14/2014 04:03 PM, Gerd Hoffmann wrote:
...
On Fr, 2014-11-14 at 14:54 +0100, Pavel Hrdina wrote:
...
+static struct virQEMUCapsStringFlags
virQEMUCapsObjectPropsCirrusVga[] = {
+    { "vgamem_mb", QEMU_CAPS_CIRRUS_VGA_VGAMEM },
+};
Please don't touch vgamem_mb on cirrus.  The only reason we have this
property in the first place is live migration compatibility (default vga
mem used to be 8MB, but is 16 MB on recent machine types).
cheers,
   Gerd
So you are saying that we should not allow setting the 'vgamem_mb' for
cirrus? Is there any reason for that?

Pavel