On Fri, Mar 21, 2008 at 04:35:34PM -0400, Daniel Veillard wrote:
On Fri, Mar 21, 2008 at 05:39:51PM +0000, Daniel P. Berrange wrote:
On Fri, Mar 21, 2008 at 01:29:07PM -0400, Daniel Veillard wrote:
Another small issue is that I have the clone flags defined in <linux/sched.h> but not in <sched.h> so I had to add that include to get the module to compile, lxcCheckContainerSupport() check then passes on my Fedora-8 2.6.24 kernel.
I filed
https://bugzilla.redhat.com/show_bug.cgi?id=438542
to request the flags are added to sched.h too, but we should just #define them in the driver as we do for Xen hypervisor constants. This avoids a hard dependancy between the kernel used for compile, vs running.
Is that really better than #include <linux/sched.h> ? That code is linux specific after all ..
Yes it is questionable, but GLibC already contains all the other CLONE_XXX flags which are Linux specific, so I figured we might as well see if they want to include the new ones too. In any case I figure we should #ifdef & #define the new constants in lxc_driver.c, because many people's kernel headers lag behind the kernel they're compiling for. It is only recent Fedora practice to actually have the kernel headers synced to real kernel tree. Dan. -- |: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|