Re: [libvirt] [PATCH] nwfilter: use /bin/sh rather than requiring bash

On 11/15/2010 07:18 PM, Stefan Berger wrote: Aaargh. I thought I had got my libvirt-tck setup up-to-date, but it was testing the pre-patch version of libvirt. Yep - the ( and ) need quoting. I don't have time to test right now, but you can feel free to push this if it fixes the problem for you: diff --git i/src/nwfilter/nwfilter_ebiptables_driver.c w/src/nwfilter/nwfilter_ebiptables_driver.c index c3a0d3e..7b2a505 100644 --- i/src/nwfilter/nwfilter_ebiptables_driver.c +++ w/src/nwfilter/nwfilter_ebiptables_driver.c @@ -61,7 +61,7 @@ #define CMD_DEF_PRE "cmd='" #define CMD_DEF_POST "'" #define CMD_DEF(X) CMD_DEF_PRE X CMD_DEF_POST -#define CMD_EXEC "eval res=\\$(\"${cmd}\")" CMD_SEPARATOR +#define CMD_EXEC "eval res=\\$\\(\"${cmd}\"\\)" CMD_SEPARATOR #define CMD_STOPONERR(X) \ X ? "if [ $? -ne 0 ]; then" \ " echo \"Failure to execute command '${cmd}'.\";" \ -- Eric Blake eblake(a)redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org