On Thu, Jul 22, 2010 at 04:01:53PM -0700, Chris Wright wrote:
The first conditional is always true which means the iterator will never find another device on the same bus.
if (dev->domain != check->domain || dev->bus != check->bus || ----> (check->slot == check->slot && check->function == check->function)) <-----
The goal of that check is to verify that the device is either:
in a different pci domain on a different bus is the same identical device
This means libvirt may issue a secondary bus reset when there are devices on that bus that actively in use by the host or another guest. Not good. Fix the typo.
Oops ! Good catch, pushed, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/