Re: [libvirt] running Libvirt from source code, IPC_LOCK and VFIO

Hey Erik, On 2/4/19 8:11 AM, Erik Skultety wrote: Moving the code as  you suggested got rid of the internal error: --- a/src/util/virutil.c +++ b/src/util/virutil.c @@ -1587,27 +1587,6 @@ virSetUIDGIDWithCaps(uid_t uid, gid_t gid, gid_t *groups, int ngroups,          goto cleanup;      } -# ifdef PR_CAP_AMBIENT -    /* we couldn't do this in the loop earlier above, because the capabilities -     * were not applied yet, since in order to add a capability into the AMBIENT -     * set, it has to be present in both the PERMITTED and INHERITABLE sets -     * (capabilities(7)) -     */ -    for (i = 0; i <= CAP_LAST_CAP; i++) { -        capstr = capng_capability_to_name(i); - -        if (capBits & (1ULL << i)) { -            if (prctl(PR_CAP_AMBIENT, PR_CAP_AMBIENT_RAISE, i, 0, 0) < 0) { -                virReportSystemError(errno, -                                     _("prctl failed to enable '%s' in the " -                                       "AMBIENT set"), -                                     capstr); -                goto cleanup; -            } -        } -    } -# endif -      /* Set bounding set while we have CAP_SETPCAP.  Unfortunately we cannot       * do this if we failed to get the capability above, so ignore the       * return value. @@ -1630,6 +1609,27 @@ virSetUIDGIDWithCaps(uid_t uid, gid_t gid, gid_t *groups, int ngroups,          goto cleanup;      } +# ifdef PR_CAP_AMBIENT +    /* we couldn't do this in the loop earlier above, because the capabilities +     * were not applied yet, since in order to add a capability into the AMBIENT +     * set, it has to be present in both the PERMITTED and INHERITABLE sets +     * (capabilities(7)) +     */ +    for (i = 0; i <= CAP_LAST_CAP; i++) { +        capstr = capng_capability_to_name(i); + +        if (capBits & (1ULL << i)) { +            if (prctl(PR_CAP_AMBIENT, PR_CAP_AMBIENT_RAISE, i, 0, 0) < 0) { +                virReportSystemError(errno, +                                     _("prctl failed to enable '%s' in the " +                                       "AMBIENT set"), +                                     capstr); +                goto cleanup; +            } +        } +    } +# endif + However, this code still doesn't add IPC_LOCK as capability: index 0d58f1ee57..f4b46abc08 100644 --- a/src/util/virutil.c +++ b/src/util/virutil.c +++ b/src/qemu/qemu_capabilities.c @@ -4525,6 +4525,9 @@ virQEMUCapsInitQMPCommandRun(virQEMUCapsInitQMPCommandPtr cmd,      /* QEMU might run into permission issues, e.g. /dev/sev (0600), override       * them just for the purpose of probing */      virCommandAllowCap(cmd->cmd, CAP_DAC_OVERRIDE); +    virCommandAllowCap(cmd->cmd, CAP_IPC_LOCK); +    virCommandAllowCap(cmd->cmd, CAP_IPC_OWNER); +  #endif So I am not sure if my mod above is wrong or your suggestion of moving the PR_CAP_AMBIENT code made the warning go away but isn't setting the capabilities at all. I'll investigate it more. DHB