Re: [libvirt] [PATCH v2 0/3] adding virGetLastErrorCode/Domain to paritally replace virGetLastError
Patch looks good, many thanks Eric.
Ramy
On Wed, May 9, 2018 at 12:58 PM, Erik Skultety <eskultet(a)redhat.com> wrote:
On Sat, May 05, 2018 at 01:04:18PM +0100, ramyelkest wrote:
> Changes from v1[1]:
>
> * removed virHasLastError() and s/virHasLastError/virGetLastErrorCode/g
> * replaced in missed files: virmodule.c and virnetlibsshsession.c
> * better split of patches
>
> [1] https://www.redhat.com/archives/libvir-list/2018-May/msg00259.html
>
> ramyelkest (3):
> util: cleanup: using virGetLastErrorMessage instead of err->message
> util: added virGetLastErrorCode/Domain
> all: replacing virGetLastError with virGetLastErrorCode where we can
I suggested some minor adjustments to your patches without the need for a v3,
so let me know if you agree and I'll merge the series.
Erik