On 05/01/2014 06:05 PM, Tomoki Sekiyama wrote:
New rules are added in fixup_name in gendispatch.pl to keep the name FSFreeze and FSThaw. This adds a new ACL permission 'fs_freeze', which is also applied to VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE flag.
Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@hds.com> Acked-by: Daniel P. Berrange <berrange@redhat.com> --- src/access/viraccessperm.c | 2 +- src/access/viraccessperm.h | 6 ++++++ src/remote/remote_driver.c | 2 ++ src/remote/remote_protocol.x | 38 ++++++++++++++++++++++++++++++++++++-- src/remote_protocol-structs | 18 ++++++++++++++++++
'make check' says you missed some pieces here: --- remote_protocol-structs 2014-05-06 17:53:59.624852386 -0600 +++ remote_protocol-struct-t3 2014-05-06 17:55:10.878391439 -0600 @@ -2435,6 +2435,9 @@ } mountpoints; u_int flags; }; +struct remote_domain_fsfreeze_ret { + int filesystems; +}; struct remote_domain_fsthaw_args { remote_nonnull_domain dom; struct { @@ -2443,6 +2446,9 @@ } mountpoints; u_int flags; }; +struct remote_domain_fsthaw_ret { + int filesystems; +}; enum remote_procedure { REMOTE_PROC_CONNECT_OPEN = 1, REMOTE_PROC_CONNECT_CLOSE = 2,
+ /** + * @desc: Freeze and thaw domain filesystems + * @message: Freezing and thawing domain filesystems require authorization
s/require/requires/ Fixed and pushed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org