Re: [libvirt] [PATCH]Fix minor issues in logical storage backend

On Thu, Sep 04, 2008 at 03:13:45PM +0200, Daniel Veillard wrote: > So there is an initialization of the field. It's unclear to me if > the two should be OR'ed, or should be kept as-is, if we have the pool > name do we need to provide the pool device then ? I get a bit confused > now. The .flag field is a bit-mask, so yes it should be OR'd. Basically the flags are saying which XML elements are valid within the <source> tag, and in LVM case we need to allow both <name> and <device> tags, so they have to be OR'd