Re: [libvirt] [PATCH] qemu driver: fix version check typos

19 May 2010

On 05/19/2010 04:37 PM, Chris Wright wrote:
...
Looks like some cut'n paste error to me.
Signed-off-by: Chris Wright <chrisw@redhat.com>
---
 src/qemu/qemu_conf.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 3e334dc..6d2ac6e 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_conf.c
@@ -1291,13 +1291,13 @@ int qemudParseHelpStr(const char *qemu,
     ++p;
minor = virParseNumber(&p);
-    if (major == -1 || *p != '.')
+    if (minor == -1 || *p != '.')
         goto fail;
++p;
micro = virParseNumber(&p);
-    if (major == -1)
+    if (micro == -1)
ACK.

-- 
Eric Blake   eblake@redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

    