Re: [libvirt] [PATCH v4 2/2]testcase: Add a new USB option test case
On 2013年04月11日 17:31, Daniel P. Berrange wrote:
On Sun, Apr 07, 2013 at 04:31:58PM +0800, Li Zhang wrote:
> From: Li Zhang <zhlcindy(a)linux.vnet.ibm.com>
>
> Add one test case to test CLI with -machine xxx,usb=off.
>
> Signed-off-by: Li Zhang <zhlcindy(a)linux.vnet.ibm.com>
> ---
> .../qemuxml2argv-machine-usb-opt.args | 5 +++++
> .../qemuxml2argv-machine-usb-opt.xml | 26 ++++++++++++++++++++++
> tests/qemuxml2argvtest.c | 2 ++
> 3 files changed, 33 insertions(+)
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-usb-opt.args
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-usb-opt.xml
ACK, but we should merge it into the previous patch before
adding to git - basically always include the test cases in
the same patch that you include the new feature in.
Got it, thanks a lot. :)
Daniel