Re: [libvirt] [PATCH] command: Discard FD_SETSIZE limit for opened files

On Tue, Jan 03, 2012 at 09:33:03AM -0700, Eric Blake wrote: > On 01/03/2012 04:14 AM, Michal Privoznik wrote: >> Currently, virCommand implementation uses FD_ macros from >> sys/select.h. However, those cannot handle more opened files >> than FD_SETSIZE. Therefore switch to generalized implementation >> based on array of integers. >> --- >> src/util/command.c | 108 ++++++++++++++++++++++++++++++++++++++++------------ >> 1 files changed, 83 insertions(+), 25 deletions(-) > > NACK. While I agree with the idea, I'd rather use virBitmap rather than > open-coding an int array ourselves. Is it worth considering the efficiency implications of virBitmap in this use case ? Michal's initial patch is pretty time & space efficient, since we only need to store & iterate over an array that is equal in size to the number of preserved FDs. Now if we want to create a new 'virSet' class for efficiently dealing with sparse sets.....otherwise I'm inclined to say this patch is fine as it is.