Re: [libvirt] [PATCH] Reusing the result of virArchFromHost instead of calling it multiple times

On Mon, Apr 8, 2013 at 4:32 PM, Daniel P. Berrange <berrange(a)redhat.com&gt;wrote: > On Mon, Apr 08, 2013 at 03:33:07PM +0300, Tal Kain wrote: >> Signed-off-by: Tal Kain <tal.kain(a)ravellosystems.com&gt; >> --- >> src/qemu/qemu_capabilities.c | 13 +++++++------ >> 1 file changed, 7 insertions(+), 6 deletions(-) > > What is the motivation for doing this ? it just looks like > overkill to me, since virArchFromHost isn't really an > expensive method to invoke. >

This patch's motivation is not about making this function faster. Even if virArchFromHost isn't expensive, It seemed to me like there is no good reason for calling it 3 times at the same context, It is just unnecessary. Why using a local variable instead of calling the same function three times is an overkill?

>From my perspective, by calling it just once I'm making it easier for a reader to understand the usage of this function without reading its code.