Re: [libvirt] [PATCH 1/3] util: add Intel x86 RDT/CMT support
See my update inline.
-----Original Message-----
From: Martin Kletzander [mailto:mkletzan@redhat.com]
Sent: Monday, June 11, 2018 4:40 PM
To: Wang, Huaqiang <huaqiang.wang(a)intel.com>
Cc: libvir-list(a)redhat.com; Feng, Shaohe <shaohe.feng(a)intel.com>; Niu, Bing
<bing.niu(a)intel.com>; Ding, Jian-feng <jian-feng.ding(a)intel.com>; Zang, Rui
<rui.zang(a)intel.com>
Subject: Re: [libvirt] [PATCH 1/3] util: add Intel x86 RDT/CMT support
On Fri, Jun 08, 2018 at 05:02:17PM +0800, Wang Huaqiang wrote:
>Add RDT/CMT feature (Intel x86) by interacting with kernel resctrl file system.
Integrate code into util/resctrl.
>---
> src/libvirt_private.syms | 9 ++
> src/util/virresctrl.c | 316
++++++++++++++++++++++++++++++++++++++++++++++-
> src/util/virresctrl.h | 44 +++++++
> 3 files changed, 367 insertions(+), 2 deletions(-)
>
This will not merge after some of the cleanups I made. There is one more patch
that didn't get in and you clould look there for some inspiration as well, but
it's
just about keeping the data in another part of the code.
Anyway the conflict is very easy to fix now.
Why isn't it just a matter of setting a boolean?
Aling the code and run the checks before posting to the list. For more info see
contribution guidelines:
https://libvirt.org/hacking.html
Yes, noticed your patch. I'd like to make changes accordingly.
Will follow the rules listed in "https://libvirt.org/hacking.html" and take care
the coding style. Thanks very much.