Re: [libvirt] [PATCH 2/7] conf: Add support for storage state directory
On 03/24/2015 06:06 AM, Erik Skultety wrote:
Before introducing necessary changes to storage_driver.c, first
prepare
our structures for storage state XML support.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1177733
---
src/conf/storage_conf.h | 1 +
src/storage/storage_driver.c | 1 +
2 files changed, 2 insertions(+)
I think patch 3 could go ahead of this - introducing the save function
first so it's ready to be used by following patches.
While this being separate is nice/simple - it seems patch 4 & 7 should
be merged with this
John
diff --git a/src/conf/storage_conf.h b/src/conf/storage_conf.h
index 4584075..8ccc947 100644
--- a/src/conf/storage_conf.h
+++ b/src/conf/storage_conf.h
@@ -293,6 +293,7 @@ struct _virStorageDriverState {
char *configDir;
char *autostartDir;
+ char *stateDir;
bool privileged;
};
diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index 64ea770..e088ffa 100644
--- a/src/storage/storage_driver.c
+++ b/src/storage/storage_driver.c
@@ -261,6 +261,7 @@ storageStateCleanup(void)
VIR_FREE(driver->configDir);
VIR_FREE(driver->autostartDir);
+ VIR_FREE(driver->stateDir);
storageDriverUnlock();
virMutexDestroy(&driver->lock);
VIR_FREE(driver);