Re: [PATCH v2 32/34] syms: admin: Add sections to match when API was introduced
On Tue, Apr 19, 2022 at 03:26:45PM +0200, Peter Krempa wrote:
On Thu, Apr 14, 2022 at 22:47:43 +0200, Victor Toso wrote:
> Discover this mismatch with the docstring work.
> scripts/apibuild.py complained.
>
> Signed-off-by: Victor Toso <victortoso(a)redhat.com>
> ---
> src/admin/libvirt_admin_public.syms | 58 ++++++++++++++++++++++-------
> 1 file changed, 45 insertions(+), 13 deletions(-)
As noted in the reply to the cover letter:
NACK, this breaks existing builds of apps which link against the admin
client library:
Further, the current .syms file is actually correct, though it
may not be obvious if you look at git history.
We comitted stuff incrementally in earlier versions, but it was
not actually consumable by apps until 2.0.0, hence the version
was set to 2.0.0 by:
commit 52dbacc07a693e14079c445ec677ab03a0888106
Author: Erik Skultety <eskultet(a)redhat.com>
Date: Fri Jun 24 19:27:09 2016 +0200
admin: enable both admin API functionality and tarball distribution
This patch enables admin socket creation in daemon's code, bumps the library
version in libvirt_admin_public.syms, and performs all necessary modifications
to our makefiles so that admin API can finally be included in the tarball,
and eventually become part of an rpm package (a patch later in this series).
Signed-off-by: Erik Skultety <eskultet(a)redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|