On Wed, Jul 11, 2007 at 05:06:31PM +0100, Daniel P. Berrange wrote:
On Wed, Jul 11, 2007 at 12:02:26PM -0400, Daniel Veillard wrote:
On Wed, Jul 11, 2007 at 04:36:23PM +0100, Richard W.M. Jones wrote:
This can prove useful if we want to track down problems like the double-call of domainSuspend.
Also attached below is the output of virt-manager when this tracing is enabled.
Note that if --enable-debug is not set, then no extra code is added to libvirt.
I would like this, I have just one thing which worries me, it's the vararg macros, I'm not sure how widely it's supported outside of gcc ..
If it doesn't work on non-GCC, then those people can simply not add --enable-debug to their configure flags.
Disagree +#define DEBUG0 +#define DEBUG(fs,...) +#endif /* !ENABLE_DEBUG */ just won't work for them, not all statements are within #ifdef ENABLE_DEBUG #endif it won't compile even if ENABLE_DEBUG is not defined. Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/