Re: [libvirt] [PATCH v2 2/5] Wire protocol and dispatcher for virDomainMigrateSetMaxDowntime
On 03/19/2010 04:37 AM, Daniel Veillard wrote:
> -# define REMOTE_STRING_MAX 65536
> +#include "internal.h"
> +#include <arpa/inet.h>
> +#define REMOTE_MESSAGE_MAX 262144
> +#define REMOTE_MESSAGE_HEADER_MAX 24
> +#define REMOTE_MESSAGE_PAYLOAD_MAX 262120
> +#define REMOTE_STRING_MAX 65536
painful because it's generated, if you don't have cppi installed
make "syntax-check" won't complain, but I'm afraid it will for those
where this is present. I think the patch is fine, we just need to make
sure that generated file is not checked for the cppi test,
Yes, remote_protocol.h is already exempted from the cppi test. I did a
global update, knowing that exempted files would be swapped back, but
this should still pass 'make syntax-check' even with cppi installed.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 323 bytes)