On 08/12/2016 09:33 AM, Jiri Denemark wrote:
The function filters all CPU features through a given callback while copying CPU model related parts of a CPU definition.
Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- src/conf/cpu_conf.c | 31 ++++++++++++++++++++++++------- src/conf/cpu_conf.h | 12 ++++++++++++ src/libvirt_private.syms | 1 + 3 files changed, 37 insertions(+), 7 deletions(-)
diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index 13f3da3..b74c48b 100644 --- a/src/conf/cpu_conf.c +++ b/src/conf/cpu_conf.c @@ -86,28 +86,45 @@ virCPUDefCopyModel(virCPUDefPtr dst, const virCPUDef *src, bool resetPolicy) { + return virCPUDefCopyModelFilter(dst, src, resetPolicy, NULL, NULL); +} + + +int ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2)
Any particular advantage to putting the NONNULL in both the .h file and here? I see virCPUDefCopyModel is similar.
+virCPUDefCopyModelFilter(virCPUDefPtr dst, + const virCPUDef *src, + bool resetPolicy, + virCPUDefFeatureFilter filter, + void *opaque) +{
[...]