Re: [PATCH 25/33] qemu: Add qemuDomainDefaultSerialModel()

On Wed, Jan 24, 2024 at 20:37:45 +0100, Andrea Bolognani wrote:

Factor out the existing code.

Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- src/qemu/qemu_domain.c | 66 ++++++++++++++++++++++-------------------- 1 file changed, 35 insertions(+), 31 deletions(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index b3e63b3648..c9d213dd7b 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -4312,6 +4312,40 @@ qemuDomainDefaultSerialType(const virDomainDef *def) }

+static int

IMO at this point you can return virDomainChrSerialTargetModel.