Re: [libvirt] [dbus PATCH v3 5/5] docs: rewrite HACKING and README into markdown format and improve it
On Wed, Mar 21, 2018 at 02:29:00PM +0000, Daniel P. Berrangé wrote:
On Wed, Mar 21, 2018 at 11:02:47AM +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
> ---
> HACKING | 199 ------------------------------------------------------------
> HACKING.md | 191 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> Makefile.am | 2 +
> README | 80 ------------------------
> README.md | 72 ++++++++++++++++++++++
> 5 files changed, 265 insertions(+), 279 deletions(-)
> delete mode 100644 HACKING
> create mode 100644 HACKING.md
> delete mode 100644 README
> create mode 100644 README.md
I'm a little surprised autoconf doesn't complain about the missing
README file now ?
autoconf doesn't complain about it, I've run ./autogen.sh and
"make distcheck" and I've also tried building it in centos7 using mock
and everything looks good.
BTW: I forgot to update spec file, but I'll fix it before pushing.
If it does, then add a symlink to git. Either way
Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com>
Thanks for review, I'll push it shortly.
Pavel
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)