On 06/13/2016 03:29 AM, Michal Privoznik wrote:
On 11.06.2016 00:34, Jim Fehlig wrote:
> This is essentially a V3 of
>
>
https://www.redhat.com/archives/libvir-list/2016-April/msg01358.html
>
> To avoid code duplication in that series, I proposed adding
> a virFirmware object that could be used by multiple drivers
>
>
https://www.redhat.com/archives/libvir-list/2016-May/msg01370.html
>
> mprivozn ACK'ed that series, but I deferred committing it until
> 1.3.5 was released since it's not all that useful without
> accompanying use by another driver.
>
> Jim Fehlig (6):
> driver config: Introduce virFirmware object
> libxl: add default firmwares to driver config object
> libxl: introduce libxl_capabilities.{ch}
> libxl: implement connectGetDomainCapabilities
> xenconfig: support bios=ovmf xl.cfg
> libxl: Add support for ovmf firmware
>
> po/POTFILES.in | 2 +
> src/Makefile.am | 12 +-
> src/libvirt_private.syms | 6 +
> src/libxl/libxl_capabilities.c | 598 +++++++++++++++++++++++++++++
> src/libxl/libxl_capabilities.h | 57 +++
> src/libxl/libxl_conf.c | 460 ++--------------------
> src/libxl/libxl_conf.h | 22 +-
> src/libxl/libxl_domain.c | 1 +
> src/libxl/libxl_driver.c | 75 ++++
> src/qemu/qemu_capabilities.c | 22 +-
> src/qemu/qemu_capabilities.h | 5 +-
> src/qemu/qemu_conf.c | 127 +-----
> src/qemu/qemu_conf.h | 7 +-
> src/qemu/qemu_driver.c | 2 +-
> src/qemu/qemu_process.c | 6 +-
> src/util/virfirmware.c | 137 +++++++
> src/util/virfirmware.h | 51 +++
> src/xenconfig/xen_xl.c | 37 +-
> tests/Makefile.am | 5 +
> tests/domaincapsschemadata/libxl-xenfv.xml | 68 ++++
> tests/domaincapsschemadata/libxl-xenpv.xml | 58 +++
> tests/domaincapstest.c | 64 ++-
> tests/testutils.c | 16 +
> tests/testutils.h | 2 +
> tests/testutilsxen.h | 1 +
> tests/xlconfigdata/test-fullvirt-ovmf.cfg | 26 ++
> tests/xlconfigdata/test-fullvirt-ovmf.xml | 58 +++
> tests/xlconfigtest.c | 90 ++++-
> 28 files changed, 1415 insertions(+), 600 deletions(-)
> create mode 100644 src/libxl/libxl_capabilities.c
> create mode 100644 src/libxl/libxl_capabilities.h
> create mode 100644 src/util/virfirmware.c
> create mode 100644 src/util/virfirmware.h
> create mode 100644 tests/domaincapsschemadata/libxl-xenfv.xml
> create mode 100644 tests/domaincapsschemadata/libxl-xenpv.xml
> create mode 100644 tests/xlconfigdata/test-fullvirt-ovmf.cfg
> create mode 100644 tests/xlconfigdata/test-fullvirt-ovmf.xml
>
ACK series
Thanks! I've pushed this now without making any changes to 5/6, but can
certainly send follow-ups to rework anything we deem needs reworking.
Regards,
Jim