Re: [Libvir] [PATCH] Solaris dom0 support

> I'm getting a little confused about the xen_internal.c changes for the > hypercalls. > > This is chunk: Yeah, another funcky diff.. I'll send a different diff for this file later tonight. I'm managing the changes out of a hg mq gate. > > @@ -38,6 +42,8 @@ > > #include "xml.h" > > > > /* #define DEBUG */ > > + > > +#ifdef __linux__ > > /* > > * so far there is 2 versions of the structures usable for doing > > * hypervisor calls. > > @@ -60,6 +66,14 @@ typedef struct v1_hypercall_struct > > _IOC(_IOC_NONE, 'P', 0, sizeof(v1_hypercall_t)) > > > > typedef v1_hypercall_t hypercall_t; > > + > > +#else > > +typedef struct v0_hypercall_struct { > > + unsigned long op; > > + unsigned long arg[5]; > > +} v0_hypercall_t; > > +typedef privcmd_hypercall_t hypercall_t; > > +#endif > > Seems to be redefining v0_hypercall_t to be the same struct in both > halves of the #ifdef. But then later on, all references to v0_hypercall_t > in the code are #ifdef'd out for Solaris, and hypercall_t is defined in > terms of 'privcmd_hypercall_t' from the tools/include/SunOS/privcmd.h > which is identical to the v0_hypercall_t we've already got.