2:58 p.m.
This new subelement is used in PCI controllers: the toplevel
*attribute* "model" of a controller denotes what kind of PCI
controller is being described, e.g. a "dmi-to-pci-bridge",
"pci-bridge", or "pci-root". But in the future there will be
different
implementations of some of those types of PCI controllers, which
behave similarly from libvirt's point of view (and so should have the
same model), but use a different device in qemu (and present
themselves as a different piece of hardware in the guest). In an ideal
world we (i.e. "I") would have thought of that back when the pci
controllers were added, and used some sort of type/class/model
notation (where class was used in the way we are now using model, and
model was used for the actual manufacturer's model number of a
particular family of PCI controller), but that opportunity is long
past, so as an alternative, this patch allows selecting a particular
implementation of a pci controller with the "name" attribute of the
<model> subelement, e.g.:
<controller type='pci' model='dmi-to-pci-bridge'
index='1'>
<model name='i82801b11-bridge'/>
</controller>
In this case, "dmi-to-pci-bridge" is the kind of controller (one that
has a single PCIe port upstream, and 32 standard PCI ports downstream,
which are not hotpluggable), and the qemu device to be used to
implement this kind of controller is named "i82801b11-bridge".
Implementing the above now will allow us in the future to add a new
kind of dmi-to-pci-bridge that doesn't use qemu's i82801b11-bridge
device, but instead uses something else (which doesn't yet exist, but
qemu people have been discussing it), all without breaking existing
configs.
(note that for the existing "pci-bridge" type of PCI controller, both
the model attribute and <model> name are 'pci-bridge'. This is just a
coincidence, since it turns out that in this case the device name in
qemu really is a generic 'pci-bridge' rather than being the name of
some real-world chip)
---
change from V2:
* attribute is now called "name" instead of "type"
* different possible model names are stored internally as an enum
value rather than a string.
* more than one occurence of <model> in a single controller is now
considered an error
* docs say "1.2.18" instead of "1.3.0"
docs/formatdomain.html.in | 13 +++++++
docs/schemas/domaincommon.rng | 13 +++++++
src/conf/domain_conf.c | 46 +++++++++++++++++++++++--
src/conf/domain_conf.h | 16 +++++++++
src/libvirt_private.syms | 2 ++
tests/qemuxml2argvdata/qemuxml2argv-q35.xml | 8 +++--
tests/qemuxml2xmloutdata/qemuxml2xmlout-q35.xml | 8 +++--
7 files changed, 100 insertions(+), 6 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index d0c1741..9abceee 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -3042,6 +3042,19 @@
(set to 0). <span class="since">Since 1.1.2 (QEMU
only)</span>
</p>
<p>
+ PCI controllers also have an optional
+ subelement <code><model></code> with an attribute
+ <code>name</code>. The name attribute holds the name of the
+ specific device that qemu is emulating (e.g. "i82801b11-bridge")
+ rather than simply the class of device ("dmi-to-pci-bridge",
+ "pci-bridge"), which is set in the controller element's
+ model <b>attribute</b>. In almost all cases, you should not
+ manually add a <code><model></code> subelement to a
+ controller, nor should you modify one that is automatically
+ generated by libvirt. <span class="since">Since 1.2.18 (QEMU
+ only).</span>
+ </p>
+ <p>
For machine types which provide an implicit PCI bus, the pci-root
controller with index=0 is auto-added and required to use PCI devices.
pci-root has no address.
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index 1120003..a4c1c9b 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -1731,6 +1731,19 @@
<attribute name="type">
<value>pci</value>
</attribute>
+ <optional>
+ <element name="model">
+ <attribute name="name">
+ <choice>
+ <!-- implementations of 'pci-bridge' -->
+ <value>pci-bridge</value>
+ <!-- implementations of 'dmi-to-pci-bridge' -->
+ <value>i82801b11-bridge</value>
+ </choice>
+ </attribute>
+ <empty/>
+ </element>
+ </optional>
<!-- *-root controllers have an optional element
"pcihole64"-->
<choice>
<group>
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 6b557d1..d58e679 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -326,6 +326,12 @@ VIR_ENUM_IMPL(virDomainControllerModelPCI,
VIR_DOMAIN_CONTROLLER_MODEL_PCI_LAST,
"pci-bridge",
"dmi-to-pci-bridge")
+VIR_ENUM_IMPL(virDomainControllerPCIModelName,
+ VIR_DOMAIN_CONTROLLER_PCI_MODEL_NAME_LAST,
+ "none",
+ "pci-bridge",
+ "i82801b11-bridge")
+
VIR_ENUM_IMPL(virDomainControllerModelSCSI, VIR_DOMAIN_CONTROLLER_MODEL_SCSI_LAST,
"auto",
"buslogic",
@@ -7766,6 +7772,8 @@ virDomainControllerDefParseXML(xmlNodePtr node,
char *queues = NULL;
char *cmd_per_lun = NULL;
char *max_sectors = NULL;
+ bool processedModel = false;
+ char *modelName = NULL;
xmlNodePtr saved = ctxt->node;
int rc;
@@ -7809,6 +7817,15 @@ virDomainControllerDefParseXML(xmlNodePtr node,
queues = virXMLPropString(cur, "queues");
cmd_per_lun = virXMLPropString(cur, "cmd_per_lun");
max_sectors = virXMLPropString(cur, "max_sectors");
+ } else if (xmlStrEqual(cur->name, BAD_CAST "model")) {
+ if (processedModel) {
+ virReportError(VIR_ERR_XML_ERROR, "%s",
+ _("Multiple <model> elements in "
+ "controller definition not allowed"));
+ goto error;
+ }
+ modelName = virXMLPropString(cur, "name");
+ processedModel = true;
}
}
cur = cur->next;
@@ -7917,6 +7934,15 @@ virDomainControllerDefParseXML(xmlNodePtr node,
def->opts.pciopts.pcihole64size = VIR_DIV_UP(bytes, 1024);
}
}
+ if (modelName &&
+ (def->opts.pciopts.modelName
+ = virDomainControllerPCIModelNameTypeFromString(modelName)) <= 0) {
+ virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+ _("Unknown PCI controller model name
'%s'"),
+ modelName);
+ goto error;
+ }
+ break;
default:
break;
@@ -7941,6 +7967,7 @@ virDomainControllerDefParseXML(xmlNodePtr node,
VIR_FREE(queues);
VIR_FREE(cmd_per_lun);
VIR_FREE(max_sectors);
+ VIR_FREE(modelName);
return def;
@@ -18950,7 +18977,8 @@ virDomainControllerDefFormat(virBufferPtr buf,
{
const char *type = virDomainControllerTypeToString(def->type);
const char *model = NULL;
- bool pcihole64 = false;
+ const char *modelName = NULL;
+ bool pcihole64 = false, pciModel = false;
if (!type) {
virReportError(VIR_ERR_INTERNAL_ERROR,
@@ -18990,17 +19018,31 @@ virDomainControllerDefFormat(virBufferPtr buf,
case VIR_DOMAIN_CONTROLLER_TYPE_PCI:
if (def->opts.pciopts.pcihole64)
pcihole64 = true;
+ if (def->opts.pciopts.modelName != VIR_DOMAIN_CONTROLLER_PCI_MODEL_NAME_NONE)
+ pciModel = true;
break;
default:
break;
}
- if (def->queues || def->cmd_per_lun || def->max_sectors ||
+ if (pciModel ||
+ def->queues || def->cmd_per_lun || def->max_sectors ||
virDomainDeviceInfoNeedsFormat(&def->info, flags) || pcihole64) {
virBufferAddLit(buf, ">\n");
virBufferAdjustIndent(buf, 2);
+ if (pciModel) {
+ modelName =
virDomainControllerPCIModelNameTypeToString(def->opts.pciopts.modelName);
+ if (!modelName) {
+ virReportError(VIR_ERR_INTERNAL_ERROR,
+ _("unexpected model name value %d"),
+ def->opts.pciopts.modelName);
+ return -1;
+ }
+ virBufferAsprintf(buf, "<model name='%s'/>\n",
modelName);
+ }
+
if (def->queues || def->cmd_per_lun || def->max_sectors) {
virBufferAddLit(buf, "<driver");
if (def->queues)
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index 0fe6b1a..fd65792 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -757,6 +757,14 @@ typedef enum {
} virDomainControllerModelPCI;
typedef enum {
+ VIR_DOMAIN_CONTROLLER_PCI_MODEL_NAME_NONE,
+ VIR_DOMAIN_CONTROLLER_PCI_MODEL_NAME_PCI_BRIDGE,
+ VIR_DOMAIN_CONTROLLER_PCI_MODEL_NAME_I82801B11_BRIDGE,
+
+ VIR_DOMAIN_CONTROLLER_PCI_MODEL_NAME_LAST
+} virDomainControllerPCIModelName;
+
+typedef enum {
VIR_DOMAIN_CONTROLLER_MODEL_SCSI_AUTO,
VIR_DOMAIN_CONTROLLER_MODEL_SCSI_BUSLOGIC,
VIR_DOMAIN_CONTROLLER_MODEL_SCSI_LSILOGIC,
@@ -797,6 +805,13 @@ typedef virDomainPCIControllerOpts *virDomainPCIControllerOptsPtr;
struct _virDomainPCIControllerOpts {
bool pcihole64;
unsigned long pcihole64size;
+
+ /* the exact controller name is in the "model" subelement, e.g.:
+ * <controller type='pci' model='pcie-root-port'>
+ * <model name='ioh3420''/>
+ * ...
+ */
+ int modelName; /* the exact name of the device in hypervisor */
};
/* Stores the virtual disk controller configuration */
@@ -2978,6 +2993,7 @@ VIR_ENUM_DECL(virDomainDiskDiscard)
VIR_ENUM_DECL(virDomainDiskMirrorState)
VIR_ENUM_DECL(virDomainController)
VIR_ENUM_DECL(virDomainControllerModelPCI)
+VIR_ENUM_DECL(virDomainControllerPCIModelName)
VIR_ENUM_DECL(virDomainControllerModelSCSI)
VIR_ENUM_DECL(virDomainControllerModelUSB)
VIR_ENUM_DECL(virDomainFS)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index ff322d6..37323ad 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -192,6 +192,8 @@ virDomainControllerModelSCSITypeFromString;
virDomainControllerModelSCSITypeToString;
virDomainControllerModelUSBTypeFromString;
virDomainControllerModelUSBTypeToString;
+virDomainControllerPCIModelNameTypeFromString;
+virDomainControllerPCIModelNameTypeToString;
virDomainControllerRemove;
virDomainControllerTypeToString;
virDomainCpuPlacementModeTypeFromString;
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-q35.xml
b/tests/qemuxml2argvdata/qemuxml2argv-q35.xml
index 05967a4..132c15f 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-q35.xml
+++ b/tests/qemuxml2argvdata/qemuxml2argv-q35.xml
@@ -20,8 +20,12 @@
<address type='drive' controller='0' bus='0'
target='0' unit='0'/>
</disk>
<controller type='pci' index='0' model='pcie-root'/>
- <controller type='pci' index='1'
model='dmi-to-pci-bridge'/>
- <controller type='pci' index='2' model='pci-bridge'/>
+ <controller type='pci' index='1'
model='dmi-to-pci-bridge'>
+ <model name='i82801b11-bridge'/>
+ </controller>
+ <controller type='pci' index='2' model='pci-bridge'>
+ <model name='pci-bridge'/>
+ </controller>
<video>
<model type='qxl' ram='65536' vram='32768'
vgamem='8192' heads='1'/>
</video>
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-q35.xml
b/tests/qemuxml2xmloutdata/qemuxml2xmlout-q35.xml
index 9dd4162..4d8fc5f 100644
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-q35.xml
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-q35.xml
@@ -20,8 +20,12 @@
<address type='drive' controller='0' bus='0'
target='0' unit='0'/>
</disk>
<controller type='pci' index='0' model='pcie-root'/>
- <controller type='pci' index='1'
model='dmi-to-pci-bridge'/>
- <controller type='pci' index='2' model='pci-bridge'/>
+ <controller type='pci' index='1'
model='dmi-to-pci-bridge'>
+ <model name='i82801b11-bridge'/>
+ </controller>
+ <controller type='pci' index='2' model='pci-bridge'>
+ <model name='pci-bridge'/>
+ </controller>
<controller type='sata' index='0'/>
<video>
<model type='qxl' ram='65536' vram='32768'
vgamem='8192' heads='1'/>
--
2.1.0