Roman Bogorodskiy wrote:
> + dom = virGetDomain(conn, vm->def->name,
vm->def->uuid);
> + if (!dom)
> + goto cleanup;
> +
> + ret = virBhyveProcessStart(dom->conn, privconn, vm,
> + VIR_DOMAIN_RUNNING_BOOTED,
> + start_flags);
> + if (ret) {
> + virObjectUnref(dom);
> + dom = NULL;
I think we could simplify the logic a little by calling
virBhyveProcessStart() after this block, right before
Err, virGetDomain(), not virBhyveProcessStart().
dom->id = vm->def->id; line. In that case we don't have
to jump to
cleanup and do that cleanup in if (ret) block as well.
I'm going to push that with my comments squashed in, if no objections.
Roman Bogorodskiy