Re: [libvirt] [PATCH 4/6] conf: Drop unused VIR_DOMAIN_DEF_FORMAT_UPDATE_CPU

On 09/18/2017 03:35 PM, Jiri Denemark wrote: > The only real usage of this flag was removed by "cpu_conf: Drop > updateCPU from virCPUDefFormat". >

> diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h > index bb3b6f0c3c..4603e4f97e 100644 > --- a/src/conf/domain_conf.h > +++ b/src/conf/domain_conf.h > @@ -2857,7 +2857,6 @@ typedef enum { > typedef enum { > VIR_DOMAIN_DEF_FORMAT_SECURE = 1 << 0, > VIR_DOMAIN_DEF_FORMAT_INACTIVE = 1 << 1, > - VIR_DOMAIN_DEF_FORMAT_UPDATE_CPU = 1 << 2, > VIR_DOMAIN_DEF_FORMAT_MIGRATABLE = 1 << 3, > /* format internal domain status information */ > VIR_DOMAIN_DEF_FORMAT_STATUS = 1 << 4, Should we update these so that the flags are consecutive? VIR_DOMAIN_DEF_FORMAT_MIGRATABLE can be 1 << 2, VIR_DOMAIN_DEF_FORMAT_STATUS can be 1 << 3, and so on. These are just internal flags so there would be no ABI brekage if we do that.